Open
Conversation
minor vignette edit
Collaborator
Author
|
I didn't see that you already approved the PR for the vignette fix. This addition affects the R script & man page:
|
5 tasks
kyleGrealis
commented
Jan 9, 2026
| #' @description There is a reported issues with joins on data (without a reprex) | ||
| #' that seem to be caused by the labels. As a possible solution this can be | ||
| #' used to drop labels. | ||
| #' Drop the label from one or more variables |
Collaborator
Author
There was a problem hiding this comment.
@RaymondBalise please review these edits and let me know if this should be kept or moved to another release(?). It would allow for using tidyselect methods to drop from one or more variables within the same function call.
kyleGrealis
commented
Jan 9, 2026
| c(1, 2, 3, 4, 5), | ||
| label = "Study ID", | ||
| class = c("labelled", "numeric") | ||
| # 01.09.2026: REDCapR >= 1.2.0 returns tibbles instead of data.frames. |
Collaborator
Author
There was a problem hiding this comment.
@RaymondBalise : removed the "labelled" attribute as the upstream demographics data has changed. See URL included in the comment
kyleGrealis
commented
Jan 9, 2026
Collaborator
Author
kyleGrealis
left a comment
kyleGrealis
left a comment
There was a problem hiding this comment.
Review package changes 01.09.2026
Collaborator
Author
|
@RaymondBalise, though there are many conflicts in this PR, reopening in case there are fixes within that are needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor vignette edit